doc: fix api docs style #13700
Closed
doc: fix api docs style #13700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamingr
approved these changes
Jun 15, 2017
cjihrig
approved these changes
Jun 15, 2017
jasnell
approved these changes
Jun 15, 2017
refack
approved these changes
Jun 15, 2017
| @@ -2854,7 +2854,6 @@ The following constants are meant for use with the [`fs.Stats`][] object's | |||
| [Caveats]: #fs_caveats | |||
| [Common System Errors]: errors.html#errors_common_system_errors | |||
| [FS Constants]: #fs_fs_constants_1 | |||
| [MDN-Date-getTime]: https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Date/getTime | |||
doc/api/async_hooks.md
Outdated
| @@ -195,7 +195,7 @@ The `type` is a string that represents the type of resource that caused | |||
| `init` to be called. Generally it will correspond the name of the resource's | |||
| constructor. | |||
|
|
|||
| ``` | |||
| ```csv | |||
There was a problem hiding this comment.
Nit: I think YAML or even simply text is more correct...
There was a problem hiding this comment.
The values in this part are separated only by a comma, but I agree on using text since it's not a data for csv/yaml. Will do! Thanks :)
lpinca
approved these changes
Jun 15, 2017
mhdawson
approved these changes
Jun 16, 2017
watilde
force-pushed
the
feature/docs-patch
branch
from
aacd268 to
046a21a
Compare
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: nodejs#13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
watilde
force-pushed
the
feature/docs-patch
branch
from
046a21a to
d6edc6d
Compare
|
Landed in 4ca3b9c. Thanks. |
watilde
added a commit
that referenced
this pull request
Jun 19, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 20, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 24, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg
pushed a commit
that referenced
this pull request
Jun 29, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
doc/api/async_hooks.md + L198: Missing code-language flag + L239: Missing code-language flag + L317: Missing code-language flag + L347: Missing code-language flag doc/api/fs.md + L2857: Unused definition PR-URL: #13700 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
|
This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
doc/api/async_hooks.md
doc/api/fs.md
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc